Skip to content
This repository has been archived by the owner on Oct 11, 2023. It is now read-only.

Improvements for Substrate #8409's bugs #257

Closed

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Mar 22, 2021

Description

Targets the problems raised in #256

  • Ignore comments from bots
  • Improve error handling
    • Context: before, error path was always posting a new Github comment indiscriminately. Now we only attempt to post a message if the comment event has not be initiated by the bot.
  • Have safer APIs based on Option and comment reasoning for being cautious around them
    • Context: part of the bug in update README.adoc substrate#8409 was due to the code expecting a field which might be missing in the API; preventive field checks motivated by safer APIs will prevent those code paths from being reached in the first place.

closes #256

@joao-paulo-parity joao-paulo-parity self-assigned this Mar 22, 2021
@joao-paulo-parity joao-paulo-parity marked this pull request as draft March 22, 2021 19:44
@joao-paulo-parity joao-paulo-parity changed the title Improvements from Substrate #8409' Improvements from Substrate #8409's bugs Mar 22, 2021
@joao-paulo-parity joao-paulo-parity changed the title Improvements from Substrate #8409's bugs Improvements for Substrate #8409's bugs Mar 22, 2021
@joao-paulo-parity joao-paulo-parity removed their assignment Mar 23, 2021
@joao-paulo-parity joao-paulo-parity force-pushed the substrate_8409 branch 2 times, most recently from 109b110 to de18a3a Compare March 24, 2021 18:34
@joao-paulo-parity joao-paulo-parity marked this pull request as ready for review March 24, 2021 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot might recursively trigger itself when posting a comment
1 participant