Skip to content

Implement codec for ethereum types #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 17, 2020
Merged

Implement codec for ethereum types #393

merged 6 commits into from
May 17, 2020

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented May 15, 2020

This adds codec support for ethbloom and ethereum-types, which is needed in Frontier.

@sorpaas
Copy link
Contributor Author

sorpaas commented May 15, 2020

This is not a breaking change so I believe a patch version bump might be enough.

@sorpaas sorpaas requested review from ordian and dvdplm and removed request for ordian May 15, 2020 17:16
ordian
ordian approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be nice to test this with --all-features in CI.

@ordian
Copy link
Contributor

ordian commented May 15, 2020

Please update the changelogs as well.

dvdplm
dvdplm approved these changes May 15, 2020
View reviewed changes
Copy link
Contributor

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

What is Frontier?

@ordian
Copy link
Contributor

ordian commented May 15, 2020

cargo fmt should fix the CI failure.

@sorpaas
Copy link
Contributor Author

sorpaas commented May 17, 2020

@dvdplm It's this -- https://github.com/paritytech/frontier
The Ethereum-compatibility layer for Substrate!

@sorpaas
Copy link
Contributor Author

sorpaas commented May 17, 2020

Published v0.9.2 for ethbloom and ethereum-types!

@sorpaas sorpaas merged commit a28452b into master May 17, 2020
@sorpaas sorpaas deleted the sp-eth-codec branch May 17, 2020 22:06
ordian pushed a commit that referenced this pull request May 18, 2020
Merge branch 'master' into ao-uint-wrapping-offset
194e923 
* master:
  uint: manually implement `Eq` and `Hash` (#390)
  uint: simplify `Ord` impl (#389)
  Implement codec for ethereum types (#393)
ordian pushed a commit that referenced this pull request Jun 12, 2020
Merge branch 'master' into ao-type-metadata
5afa279 
* master:
  uint: manually implement `Eq` and `Hash` (#390)
  uint: simplify `Ord` impl (#389)
  Implement codec for ethereum types (#393)
  update changelogs and bump versions (#387)
  prepare new `kvdb-` release (#386)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
A8-looksgood
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorpaas @ordian @dvdplm