Skip to content

Conversation

@dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Feb 8, 2020

No description provided.

@dvdplm dvdplm self-assigned this Feb 8, 2020
@dvdplm dvdplm requested review from NikVolf and ordian February 8, 2020 17:27
Co-Authored-By: Andronik Ordian <write@reusable.software>
@niklasad1
Copy link
Contributor

Can we include #337 in this release?

…itytech/parity-common into dp/chore/release-parity-crypto-0.5.0

* 'dp/chore/release-parity-crypto-0.5.0' of github.com:paritytech/parity-common:
  Update parity-crypto/CHANGELOG.md
* master:
  [parity crypto]: remove unused depend `rustc_hex` (#337)
@dvdplm
Copy link
Contributor Author

dvdplm commented Feb 8, 2020

Can we include #337 in this release?

I jumped the gun on that, apologies. rustc-hex is actually used in parity-crypto when the publickey feature is active.

@ordian
Copy link
Contributor

ordian commented Feb 8, 2020

Can we include #337 in this release?

I jumped the gun on that, apologies. rustc-hex is actually used in parity-crypto when the publickey feature is active.

Ah, good catch. Indeed

use rustc_hex::{FromHex, ToHex};

It should be optional then and included in the publickey feature set.

I assumed our tests would have caught that, would be nice to add cargo check -p parity-crypto --all-features in CI to prevent this from happening in the future.

@dvdplm dvdplm merged commit fb34955 into master Feb 8, 2020
@dvdplm dvdplm deleted the dp/chore/release-parity-crypto-0.5.0 branch February 8, 2020 20:24
ordian pushed a commit that referenced this pull request Feb 11, 2020
* origin/master:
  [parity-crypto] prepare 0.5.0 (#336)
  [parity crypto]: remove unused depend `rustc_hex` (#337)
  Update doc comment (#335)
  Add different mode for malloc_size_of_is_0 macro dealing with generics (#334)
ordian pushed a commit that referenced this pull request Feb 13, 2020
* master:
  prepare rlp-derive release (#344)
  Update/change licenses: MIT/Apache2.0 (#342)
  rlp-derive extracted (#343)
  Format for readme and changelog corrected (#341)
  Parity runtime moved to parity common for publication in crates.io (#271)
  Disable cache if explicit memory budget=0 passed (#339)
  [parity-crypto] prepare 0.5.0 (#336)
  [parity crypto]: remove unused depend `rustc_hex` (#337)
  Update doc comment (#335)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants