Skip to content

Conversation

@iamsauravsharma
Copy link
Contributor

Migrate parity-util-mem to 2018 edition
Part of #143

Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
@parity-cla-bot
Copy link

It looks like @iamsauravsharma hasn't signed our Contributor License Agreement, yet.

The purpose of a CLA is to ensure that the guardian of a project's outputs has the necessary ownership or grants of rights over all contributions to allow them to distribute under the chosen licence.
Wikipedia

You can read and sign our full Contributor License Agreement at the following URL: https://cla.parity.io

Once you've signed, please reply to this thread with [clabot:check] to prove it.

Many thanks,

Parity Technologies CLA Bot

@iamsauravsharma
Copy link
Contributor Author

[clabot:check]

@parity-cla-bot
Copy link

It looks like @iamsauravsharma signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
@dvdplm dvdplm requested a review from cheme October 1, 2019 07:02
@cheme
Copy link
Collaborator

cheme commented Oct 1, 2019

@iamsauravsharma , thanks for going through it.
Things seems fine to me, except the ci was lacking a use case, I updated things in this commit : cheme@d65d43e , see if you can add it to your PR (I think it should be removed, but still updated it).

@dvdplm
Copy link
Contributor

dvdplm commented Oct 1, 2019

(I think it should be removed, but still updated it).

Not sure I understand what you mean here: what is it that should be removed?

@cheme
Copy link
Collaborator

cheme commented Oct 1, 2019

get_malloc_size_src.sh and slim_malloc_size_of.patch (the comment with github commit to servo commit should be enough). It was probably me that wanted to keep it in the first place, but time passing I realize it does not really have any value.

Copy link
Contributor

@ordian ordian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove get_malloc_size_src.sh and slim_malloc_size_of.patch and we're good to go.

Signed-off-by: Saurav Sharma <appdroiddeveloper@gmail.com>
@ordian ordian merged commit c2f593c into paritytech:master Oct 1, 2019
@iamsauravsharma iamsauravsharma deleted the parity-util-mem-2018-edition branch October 1, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants