Fix encode-call CLI options
#868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
approved these changes
Apr 6, 2021
| let hex = encode_call.encode().unwrap(); | ||
|
|
||
| // then | ||
| assert!(format!("{:?}", hex).starts_with("0x080154556e69782074696d653a")); |
There was a problem hiding this comment.
Default payload is using current time, right? So this test will always fail
There was a problem hiding this comment.
Note that this one is not exact, but only checks the beginning (.starts_with). The timestamp comes after some prefix, so we only check the prefix.
HCastano
approved these changes
Apr 6, 2021
This was referenced Apr 6, 2021
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* added Polkadot constants * remove hardcoded constants * cargo +nightly fmt * add const existential deposit * update * cargo +nightly fmt * not pulling * readd constants.rs modules * update * Cargo.lock * update * add balance constants * Update polkadot-parachains/statemine/src/constants.rs Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com> * cargo fmt Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Mar 27, 2024
* Add tests. * Fix default and conflicting options. * Fix default variant. * Update tests.
serban300
pushed a commit
to serban300/parity-bridges-common
that referenced
this pull request
Apr 8, 2024
* Add tests. * Fix default and conflicting options. * Fix default variant. * Update tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #863
Replaces #865
I've added a bunch of remark tests to make sure that the CLI parsing works correctly. The change was supposed to be backward compatible, but I've incorrectly set
conflicts_withand forgot aboutdefault_value.