Add state to message lanes #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svyatonik
added
P-Runtime
PR-audit-needed
serban300
approved these changes
Jun 20, 2023
| data | ||
| }, | ||
| } | ||
| self.cached_data.clone() |
There was a problem hiding this comment.
Nit: I would rename the function to just data(), considering that we're not initializing it here anymore.
There was a problem hiding this comment.
Also I don't think it needs to receive &mut self anymore. &self should be enough.
svyatonik
pushed a commit
that referenced
this pull request
Jul 17, 2023
* Benchmarks script improvements * EOF --------- Co-authored-by: parity-processbot <>
bkontur
pushed a commit
that referenced
this pull request
May 7, 2024
* add LaneState enum and a field to lanes data * use OptionQuery in InboundLanes and OutboundLanes * ensure that lanes are opened when accessing them * an option to specify opened lanes in genesis config + fixed tests * added PR reference to TODO * fix failing benchmarks * spelling * get_or_init_data -> data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to #2451 and #2213
This PR introduces important change to runtime - now if the lane does not exists in the storage (
InboundLanesandOutboundLanes), we don't create it automatically. Instead we are (will for the 2nd option) provide two options:The only thing that is left here is compiling and running everything locally to be sure that I haven't forgot anything. But it isn't a stopped for reviewAll is good