Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we may remove extra folders from bridges subtree in Cumulus #1774

Closed
svyatonik opened this issue Jan 17, 2023 · 4 comments
Closed
Assignees
Labels
A-chores Something that has to be done, as part of regular maintenance
Milestone

Comments

@svyatonik
Copy link
Contributor

We may want to remove unneeded folders from the bridges subtree in Cumulus. We only need pallets, their primitives and runtime-common. But e.g. runtime-common has references to our testnets, so we can't simply remove testnet runtimes.

We need fix it (remove backreferences) and prepare some script that we may use when updating our subtree in Cumulus that will only leave required folders.

@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Jan 17, 2023
@svyatonik svyatonik added this to the Nice To Have milestone Jan 17, 2023
@svyatonik svyatonik self-assigned this Jan 18, 2023
@bkontur
Copy link
Contributor

bkontur commented Jan 19, 2023

@svyatonik
Copy link
Contributor Author

Closed #1832: ./bridges/scripts/verify-pallets-build.sh --no-revert && then git commit -a -m "Remove extra folders".

@bkontur
Copy link
Contributor

bkontur commented Feb 8, 2023

verify-pallets-build.sh is included in cumulus update subtree notes/process:
https://github.com/paritytech/cumulus/blob/bridge-hub-rococo-wococo/scripts/bridges_update_subtree.sh#L48
https://github.com/paritytech/cumulus/blob/bridge-hub-rococo-wococo/parachains/runtimes/bridge-hubs/README.md#how-to-update-bridges-subtree

I was able to create subtree update with:

./scripts/bridges_update_subtree.sh fetch
./scripts/bridges_update_subtree.sh patch (runs `verify-pallets-build.sh`)
./scripts/bridges_update_subtree.sh merge

+ some manual conflict resolution

but it is not that straight because git subtree pull creates conflicts with previously deleted files, so ./scripts/bridges_update_subtree.sh merge just deletes them and simplify conflict resolutions,
but at the end of merge process ./scripts/bridges_update_subtree.sh patch have to work and it does, so cool :)

anyway, merge conflicts will just depend on subtree diff

@bkontur
Copy link
Contributor

bkontur commented Feb 8, 2023

@svyatonik
wdyt about runnning partial-repo-build-test on all PRs?

I am just thinking, we should be able to release subtree whenever, so maybe this check should run on all PRs, ideally, it should run, if PR touches relevant files, but that is very very nice to have :)

or is there any way how to trigger partial-repo-build-test step manually in CI?

svyatonik pushed a commit that referenced this issue Jul 17, 2023
Bumps [proc-macro2](https://github.com/dtolnay/proc-macro2) from 1.0.46 to 1.0.47.
- [Release notes](https://github.com/dtolnay/proc-macro2/releases)
- [Commits](dtolnay/proc-macro2@1.0.46...1.0.47)

---
updated-dependencies:
- dependency-name: proc-macro2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Development

No branches or pull requests

2 participants