Clone only needed KademliaPeers when yielding closest nodes #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
approved these changes
Feb 18, 2025
dmitry-markin
approved these changes
Feb 21, 2025
|
@dharjeezy thank you! |
lexnv
added a commit
that referenced
this pull request
Mar 10, 2025
## [0.9.2] - 2025-03-10 This release downgrades a spamming log message to debug level and adds tests for the WebSocket stream implementation. Thanks to @dharjeezy for contributing to this release by avoiding to clone the Kademlia peers when yielding the closest nodes! ### Changed - manager: Downgrade refusing to add address log to debug ([#355](#355)) - Clone only needed KademliaPeers when yielding closest nodes ([#326](#326)) ### Added - websocket/stream/tests: Add tests for the stream implementation ([#329](#329)) cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #53