Fix no_std builds attempt 2 #78
Conversation
- Turn off default features for core in gen and genmult - Use serde-json-core (no_std support) in dev-dependencies Relates to paritytech#71
Allows us to use serde_json in dev-dependencies and compile for no_std: https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html#cargos-new-feature-resolver
|
The CI should check whether |
| @@ -7,6 +7,7 @@ authors = ["Wei Tang <hi@that.world>"] | |||
| repository = "https://github.com/paritytech/libsecp256k1" | |||
| keywords = ["crypto", "ECDSA", "secp256k1", "bitcoin", "no_std"] | |||
| edition = "2018" | |||
| resolver = "2" | |||
There was a problem hiding this comment.
This should be enough. Please revert the rest of the changes.
@athei I don't think that actually checks against a no-std target. You need to add a target like |
|
The only difference I see is that your command line is cross compiling where the CI does not. Both use |
|
@athei they both use |
* Fix no_std builds attempt 2 - Turn off default features for core in gen and genmult - Use serde-json-core (no_std support) in dev-dependencies Relates to paritytech#71 * Use resolver="2" Allows us to use serde_json in dev-dependencies and compile for no_std: https://blog.rust-lang.org/2021/03/25/Rust-1.51.0.html#cargos-new-feature-resolver * revert unnecessary changes
Relates to #71