Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes redundant util::self #63

Merged
merged 2 commits into from
May 20, 2021
Merged

Removes redundant util::self #63

merged 2 commits into from
May 20, 2021

Conversation

kigawas
Copy link
Contributor

@kigawas kigawas commented Dec 21, 2020

Rationale:

self hides the pub mod util in libsecp256k1-core implicitly, despite the intent of pub use libsecp256k1_core::*;

@kigawas
Copy link
Contributor Author

kigawas commented Dec 21, 2020

CI needs to be fixed 👀

@nothingismagick
Copy link

Yeah - I ran into this today when trying to apply the latest master branch for use in libp2p-core. 💯

@sorpaas sorpaas merged commit d2ca104 into paritytech:master May 20, 2021
@kigawas kigawas deleted the fix-util-mode branch May 20, 2021 09:32
trevor-crypto pushed a commit to monacohq/libsecp256k1 that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants