Repository navigation
Conversation
|
pr86-getcash.paseo · logs |
tiagobndr
marked this pull request as ready for review
October 7, 2026 17:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
The crypto pickers never say "Checking…". A row still being answered is drawn as a skeleton row, one per real row, matching the Figma skeleton frame.
Why
The top-up network picker showed "Checking…" under every provider network while the quote was still sizing the amount, and the withdraw pickers while the offers were being quoted. It read as a verdict. A build with the Chainflip rail off never quotes, so it still shows its greyed rows at once.
How it was tested
Unit tests, plus a headless walk of the mock world at localhost:3000 polling the DOM: top up and withdraw through Crypto show five skeleton rows, then the same five rows in place. "Checking" never appeared.
Checklist
pnpm typecheckandpnpm typecheck:packagespasspnpm testpassespnpm format:checkpasses (runpnpm formatto fix)pnpm buildsucceeds (andpnpm build:workerif the worker changed)Co-Authored-By:trailers in commits (they fail the paritytech CLA check)