Skip to content

Show skeleton rows in the crypto pickers - #86

Open
tiagobndr wants to merge 5 commits into
mainfrom
tb/picker-skeleton
Open

tiagobndr wants to merge 5 commits into
mainfrom
tb/picker-skeleton

Conversation

@tiagobndr

Copy link
Copy Markdown
Collaborator

What this changes

The crypto pickers never say "Checking…". A row still being answered is drawn as a skeleton row, one per real row, matching the Figma skeleton frame.

Why

The top-up network picker showed "Checking…" under every provider network while the quote was still sizing the amount, and the withdraw pickers while the offers were being quoted. It read as a verdict. A build with the Chainflip rail off never quotes, so it still shows its greyed rows at once.

How it was tested

Unit tests, plus a headless walk of the mock world at localhost:3000 polling the DOM: top up and withdraw through Crypto show five skeleton rows, then the same five rows in place. "Checking" never appeared.

Checklist

  • pnpm typecheck and pnpm typecheck:packages pass
  • pnpm test passes
  • pnpm format:check passes (run pnpm format to fix)
  • pnpm build succeeds (and pnpm build:worker if the worker changed)
  • Scope is one concern, and unrelated changes are not bundled in
  • Docs/comments updated where the change touches behaviour, config, or an endpoint shape
  • No Co-Authored-By: trailers in commits (they fail the paritytech CLA check)
  • No secrets, seeds, or private keys added to the repo

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

pr86-getcash.paseo · logs

https://pr86-getcash.paseo.li

@tiagobndr
tiagobndr marked this pull request as ready for review October 7, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants