This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add srtool + subwasm workflow #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A sample run can be seen here: |
apopiak
reviewed
Jun 3, 2021
| @@ -0,0 +1,58 @@ | |||
| name: Srtool build | |||
|
|
|||
| on: push | |||
There was a problem hiding this comment.
I don't think we want to run the workflow on every push?
There was a problem hiding this comment.
@s3krit Can we run it on a release? E.g. on certain branch names or tags?
There was a problem hiding this comment.
Yep dead simple - if you know the pattern of what cumulus release tags look like, you can match like so: https://github.com/paritytech/polkadot/blob/master/.github/workflows/publish-draft-release.yml#L7
(and swapping tag for branch if you want to react to a particular branch pattern)
|
Since I am off today, my prio was to have it work first so you get wasm and
blake2_256.
Sure, on push is too much. The extra runs can be cancelled manually for now
though.
The last fix i made in subwasm should make the CI as it is also pass for
westmint.
|
Co-authored-by: Alexander Popiak <alexander.popiak@gmail.com>
|
The first run including westmint can be seen here: https://github.com/chevdor/cumulus/actions/runs/902147585 |
s3krit
approved these changes
Jun 3, 2021
This was referenced Jun 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new github workflow to the CI.
It does the following:
srtoolsubwasm