-
Notifications
You must be signed in to change notification settings - Fork 379
add test-utils feature to polkadot-node-core-pvf #2989
add test-utils feature to polkadot-node-core-pvf #2989
Conversation
Merge cancelled due to error. Error: Command 'Command { std: cd "/storage/repositories/cumulus" && "git" "push" "Jpserrat" "jpserrat-add-test-utils-companion", kill_on_drop: false }' failed with status Some(1); output: To https://github.com/Jpserrat/cumulus.git |
Agh! I'll try to fix your companion. Luckily companions won't be a thing anymore soon. |
Green now. Can we merge to unblock the CI? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something with the update is wrong with the cargo update. It should be -+300 lines, not 2200.
@ggwpez What command should I run? I'm getting
|
Need this first, there is some upstream problem in Substrate master paritytech/substrate#14763 |
Got it thanks. Hopefully this is the last companion I ever have to merge. 😄 |
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ggwpez! I had tried reverting Cargo.lock then |
bot merge |
Waiting for commit status. |
Companion for paritytech/polkadot#7538