Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for #11939 #1487

Merged
merged 8 commits into from
Aug 3, 2022
Merged

Companion for #11939 #1487

merged 8 commits into from
Aug 3, 2022

Conversation

lexnv
Copy link
Contributor

@lexnv lexnv commented Aug 1, 2022

lexnv added 2 commits July 29, 2022 14:31
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
@lexnv lexnv added B0-silent Changes should not be mentioned in any release notes C1-low 📌 labels Aug 1, 2022
Copy link

@jsdw jsdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good; mix of old and new versions in the lockfile which I'd hope the build process will sort out (or can be fixed when substrate/polkadot PRs merge)?

@jsdw jsdw requested a review from niklasad1 August 1, 2022 14:14
Copy link
Member

@niklasad1 niklasad1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, revert the unrelated changes in Cargo.lock and it should be good to go

lexnv added 3 commits August 2, 2022 14:25
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
Signed-off-by: Alexandru Vasile <alexandru.vasile@parity.io>
lexnv and others added 2 commits August 2, 2022 16:05
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for b6e0cba

@niklasad1 niklasad1 merged commit acc409c into master Aug 3, 2022
@niklasad1 niklasad1 deleted the jsonrpsee_v0.15.1 branch August 3, 2022 13:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
B0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants