This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Co #5091: Runtime dependent weights for parachains #1081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added
A3-inprogress
B0-silent
This was referenced Mar 11, 2022
ggwpez
changed the title
bkchr
approved these changes
Mar 12, 2022
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| pub mod constants { |
There was a problem hiding this comment.
I don't understand all these extra constants modules. Why do we need them?
There was a problem hiding this comment.
We don't, it is just a naming convention from Substrate.
Does not really makes tbh, so I will remove them from the weight templates.
|
Waiting for commit status. |
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jun 1, 2022
2 tasks
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jun 1, 2022
jiguantong
added a commit
to darwinia-network/darwinia-parachain
that referenced
this pull request
Jun 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of just using the
polkadot-runtimeweights in the parachains 🤦 actually copy them in there.Companion for paritytech/polkadot#5091