Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Rename Statemint to Asset Hub #2591

Closed
joepetrowski opened this issue May 17, 2023 · 4 comments · Fixed by #2633
Closed

Rename Statemint to Asset Hub #2591

joepetrowski opened this issue May 17, 2023 · 4 comments · Fixed by #2633
Assignees
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category. T7-system_parachains This PR/Issue is related to System Parachains.

Comments

@joepetrowski
Copy link
Contributor

Discussed in https://forum.polkadot.network/t/the-naming-of-things-viz-statemint/2328

  • Rename folders under parachains/runtimes/assets/{statemint, statemine, westmint} to asset-hub-{polkadot, kusama, westend}
  • Casing should be:
    • asset-hub-polkadot
    • AssetHubPolkadot
    • "Asset Hub Polkadot"
  • Ensure node CLI works with asset-hub-x, but stays compatible with statemint
@joepetrowski joepetrowski added T7-system_parachains This PR/Issue is related to System Parachains. J1-meta A specific issue for grouping tasks or bugs of a specific category. labels May 17, 2023
@gilescope
Copy link
Contributor

gilescope commented May 20, 2023

We might need to fixup (/simplify) the export process to https://github.com/polkadot-fellows/runtimes once we land this.

@joepetrowski
Copy link
Contributor Author

What do you mean by the export process?

It's already "asset hub" there ;)
https://github.com/polkadot-fellows/runtimes/tree/main/system-parachains/runtimes/asset-hubs

@gilescope
Copy link
Contributor

gilescope commented May 22, 2023 via email

@PierreBesson
Copy link
Contributor

As we want to keep backward compatibility, please don't change the chainspec id in chainspec.json#L3 as this defines the database path on the disk (./chains/statemine/db). If it is changed, it would require all node operators to move files on their disk or else the node will start to resync it's database at a different path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
J1-meta A specific issue for grouping tasks or bugs of a specific category. T7-system_parachains This PR/Issue is related to System Parachains.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants