Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove system parachain native runtimes after polkadot-sdk #1737 #243

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

seadanda
Copy link
Contributor

@seadanda seadanda commented Oct 8, 2023

Changes related to #242.

Removes arguments for benchmarks for the following:

  • asset-hub-kusama and asset-hub-polkadot
  • bridge-hub-kusama and bridge-hub-polkadot
  • collectives-polkadot
  • glutton-kusama

Adds arguments for

  • collectives-westend
  • glutton-westend

To be merged after this PR in polkadot-sdk and along with this PR in command-bot-scripts

@seadanda seadanda self-assigned this Oct 8, 2023
@seadanda seadanda changed the title Remove system parachain native runtimes Remove system parachain native runtimes after polkadot-sdk #1737 Oct 8, 2023
@seadanda seadanda marked this pull request as ready for review October 8, 2023 22:54
@seadanda seadanda requested a review from a team as a code owner October 8, 2023 22:54
@mordamax
Copy link
Contributor

mordamax commented Oct 8, 2023

you can skip this, as these are just mocks for tests, they can keep working with old data.
or if you can - please update tests accordingly in guessCommand.spec.ts and parsePullRequestBotCommandLine.namedArgs.spec.ts

@seadanda
Copy link
Contributor Author

seadanda commented Oct 9, 2023

Ah nice, I missed that they were tests.

Thanks for the info, I'll take a look later and commit.

@seadanda
Copy link
Contributor Author

seadanda commented Oct 9, 2023

unit tests passing, integration tests won't pass until command-bot-scripts#52 is merged from what I understand.

@mordamax
Copy link
Contributor

mordamax commented Oct 9, 2023

@seadanda no all passed except lint

/builds/parity/mirrors/command-bot/src/command-configs/__mocks__/fetchCommandsConfiguration.ts
  148:23  error  Replace `⏎··············label:·"Runtime",⏎··············type_one_of:·["bridge-hub-rococo"],⏎···········` with `·label:·"Runtime",·type_one_of:·["bridge-hub-rococo"]`  prettier/prettier
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

i have just run yarn fix and pushed here, so should become 💚

@seadanda
Copy link
Contributor Author

seadanda commented Oct 9, 2023

Ah nice, I can't actually see the job output as I don't have a Parity Gitlab account - thanks for fixing!

@seadanda seadanda merged commit db52ea1 into master Nov 29, 2023
9 checks passed
@seadanda seadanda deleted the donal-remove-native-runtimes branch November 29, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants