Crowdloan pallet tests #189
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3c41a
reviewed
Aug 27, 2025
Comment on lines
53
to
58
| const num_active_leases = leasesArray.filter( | ||
| (lease: any) => | ||
| lease && | ||
| typeof lease === "object" && | ||
| "isSome" in lease && | ||
| lease.isSome | ||
| ).length; |
There was a problem hiding this comment.
it smells bad for me, even though I am not a TS expert. You should keep the types to be able to use isSome
There was a problem hiding this comment.
You are right, with types, the defensive checks will not be required.
x3c41a
reviewed
Aug 27, 2025
x3c41a
reviewed
Aug 27, 2025
dhirajs0
force-pushed
the
crowdloan_pallet
branch
from
1a8d9b6 to
056770c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crowdloan Pallet migration tests
This will close issue #153
WIP- need to fetch the contributors data from child state.