Conversation
|
I also added support for graph-pp, which adds precipitation-probability bars with numeric labels. 
|
|
@nbox Thanks for submitting this PR. On my radar to have a look and review it. Just haven't had much time this week. |
parente
requested review from
Copilot and
parente
and removed request for
Copilot
parente
left a comment
parente
left a comment
There was a problem hiding this comment.
@nbox Thank you for taking the time to work on this. Clearly a labor of love.
I had been thinking about richer rendering of the text data when the plug-in is active and installed so I'm glad to see you take it in that direction. I particularly like the idea of the source block content still being human readable and useful even when the Markdown is viewed elsewhere or the plug-in is uninstalled.
I left a few questions / comments in line. I think the graph rendering is the only true blocker.
| setting | ||
| .setName("Enable auto refresh") | ||
| .setDesc( | ||
| "Automatically update blocks with `date: now`, `mode: current`, or `autoRefresh: true`." |
There was a problem hiding this comment.
double-checking: This setting will turn on/off auto-refresh even for blocks that are marked autoRefresh: true? (👍 from me if so: global on/off switch)
| (hour) => | ||
| `${hour.time.format("HH:mm")} ${hour.temperature.toFixed(0)}${hour.temperatureUnit} ${hour.precipitationProbability.toFixed(0)}${hour.precipitationProbabilityUnit}` | ||
| ); | ||
| lines.push(`Next ${count}h ${parts.join(" • ")}`); |
There was a problem hiding this comment.
thought: Worth making this info easier to read when in the raw markdown (outside obsidian, when the plug-in is uninstalled?) Minimally, should the first data point align with the wind value one line up?
| {#if currentMode === "current" && showGraph && !isOffline} | ||
| {@const graphData = buildGraphData(nextHours, hourCount, showPrecip)} | ||
| {#if graphData} | ||
| <div class="graph"> |
There was a problem hiding this comment.
issue: Rendering in the default Obsidian dark & light mode themes in a fresh vault on macOS uses all black for chart colors. Are you using a custom theme in the screenshots you took? Some other factor at play?
There was a problem hiding this comment.
Hmm, that does sound like a theme/CSS-variable interaction. I’ll try to reproduce it soon on macOS in a fresh vault and test across the default light/dark themes (and a couple popular ones), then adjust the styling/colors so the chart stays readable everywhere. Thanks for catching this.
2 participants
Description
mode: currentwith current conditions, optional next‑hours line, and a compact inline graph.date: now/todayrespecttzwhen provided.Usage examples
Testing