Update httpparty dependency #47
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2020 13:10
The missing `<` would cause specs to fail.
`httpparty` version 0.13.1 has a dependency on an older version of the `json` gem. This can cause incompatibility issues on projects that include gems requiring more recent versions of the `json` gem. Beginning with version 0.14.0 of `httpparty`, the `json` dependency was removed completely. Upgrading to the latest version of `httpparty` made sense.
Closed
|
let's merge this! |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The current version of
ruby-pardothas a dependency on the0.13.0version ofhttppartywhich requires an older version of thejsongem. This can cause dependency incompatibilities when attempting to include the gem on projects that have a requirement of a newer version of thejsongem.Starting with version 0.14.0 of
httpparty, thejsondependency was removed completely. This PR updateshttppartyto the latest version.Detail
This PR does two things:
masterdue to missing characters in the XML stubs in thehttp-spechttppartygem dependency to the latest versionReferences
httppartywas pinned to0.13.0in this commithttppartywas pinned