Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON and data URL parsing and serialization support to Rust API #109

Merged
merged 2 commits into from
Jul 4, 2022

Conversation

devongovett
Copy link
Member

@devongovett devongovett commented Jul 3, 2022

Related to #68, but this only adds support to the Rust API for now. I need this in Parcel CSS.

4 new functions are added:

  • from_json
  • to_json
  • from_data_url
  • to_data_url

Eventually we could probably use these for the node/wasm bindings as well. Currently behind a json feature flag to avoid bloating people's binaries/dependencies if json support is unused.

Copy link
Member

@DeMoorJasper DeMoorJasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good. Would be nice to have the N-API api also use this as a follow-up at some point

@devongovett devongovett merged commit c28baca into master Jul 4, 2022
@devongovett devongovett deleted the json branch July 4, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants