Move all dependencies for v3 rust prototype behind a feature flag #9858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
force-pushed
the
rust-feature-flag
branch
from
4e21d2e
to
bb01243
Compare
| "mockall", | ||
| "num_cpus", | ||
| "parking_lot", | ||
| "toml", |
There was a problem hiding this comment.
Toml doesn't look used, can remove that one
MonicaOlejniczak
approved these changes
Jul 22, 2024
|
Closing in favor of #9936. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in preparation for the next v2 release. I noticed that the
@parcel/rustnpm package has grown 25% since v2.12.0 due to the addition of the rust core prototype. This moves all of that work behind a Cargo feature, which is only enabled in canary builds and development builds.