*: Fix address normalization #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
commented
Mar 24, 2022
| @@ -250,7 +258,11 @@ func (pn *profileFlatNormalizer) mapMapping(ctx context.Context, src *profile.Ma | |||
| return mapInfo{}, err | |||
| } | |||
| if m != nil { | |||
| mi := mapInfo{m, int64(m.Start) - int64(src.Start)} | |||
| // NOTICE: We only store a single version of a mapping. | |||
There was a problem hiding this comment.
@brancz I think this is the most important bit.
There was a problem hiding this comment.
Maybe slightly extend the comment with: "Which is why the client sending the profiling data can choose to normalize the mapping and address. In a future iteration of the wire format, XYZ should be included to prevent this dilemma or forcing the client to be smart in one direction or the other."
brancz
reviewed
Mar 24, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
fix_address_normalization
branch
from
ed6de6f to
4e85941
Compare
kakkoyun
commented
Mar 24, 2022
| @@ -31,7 +31,7 @@ func TestMappingKeyBytes(t *testing.T) { | |||
| Offset: 2, | |||
| } | |||
|
|
|||
| require.Equal(t, MakeMappingKey(m), []byte{ | |||
| require.Equal(t, []byte{ | |||
There was a problem hiding this comment.
This has changed because expected should be first and actual the second.
|
I think actions are completely out-of-order right now. |
brancz
approved these changes
Mar 24, 2022
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With yet to be release version of Parca Agent, we normalized addresses on the agent side. So no need to consider the mapping to normalize in the server-side for the profiles generated by the agent.