Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

area/ui: Add a Color by functionality #5114

Merged
merged 12 commits into from
Oct 29, 2024
Merged

area/ui: Add a Color by functionality #5114

merged 12 commits into from
Oct 29, 2024

Conversation

yomete
Copy link
Contributor

@yomete yomete commented Sep 19, 2024

This PR introduces a color by feature such that users can now choose how they want their icicle graph to be colored e.g. binaries and filenames.

  • Added a new "Color by" item to the "More Action" button to allow users color by either binary or filename.
    image
  • Also added a "Hidden Binaries" item so that if you filter using a binary and then switch the color by to be "Filename", you still get to see what binary you might have been filtering with previously.
    image
  • When there's just one binary, we automatically color by filename.

Also contains a fix for #5106

Copy link

alwaysmeticulous bot commented Sep 19, 2024

🤖 Meticulous spotted visual differences in 26 of 395 screens tested: view and approve differences detected.

Last updated for commit b257b8a. This comment will update as new commits are pushed.

@yomete yomete changed the title area/ui: Add a Color by functionality (wip) area/ui: Add a Color by functionality Oct 10, 2024
Copy link
Contributor

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in terms of the code, but I'll defer to Frederic/Matthias on the functionality.

@yomete yomete merged commit fd12f40 into main Oct 29, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants