fix: remove no-op if statement

parca-dev · Jul 27, 2022 · 651e419 · 651e419
1 parent 0733642
commit 651e419
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/pkg/parcacol/ingest.go b/pkg/parcacol/ingest.go
@@ -189,14 +189,12 @@ func validatePprofProfile(p *pprofproto.Profile) error {
 		if len(s.Value) != sampleLen {
 			return fmt.Errorf("mismatch: sample has %d values vs. %d types", len(s.Value), len(p.SampleType))
 		}
-		if len(s.LocationId) > 0 {
-			for j, l := range s.LocationId {
-				if l == 0 {
-					return fmt.Errorf("location ids of stacktraces must be non-zero")
-				}
-				if l > locationsNum {
-					return fmt.Errorf("sample %d location number %d (%d) is out of range", i, j, l)
-				}
+		for j, l := range s.LocationId {
+			if l == 0 {
+				return fmt.Errorf("location ids of stacktraces must be non-zero")
+			}
+			if l > locationsNum {
+				return fmt.Errorf("sample %d location number %d (%d) is out of range", i, j, l)
 			}
 		}
 		for j, label := range s.Label {