Change Options constructor visibility to public
#892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm OK with changing constructor visibility to public, go with it |
HypeMC
force-pushed
the
create-new-options-from-existing
branch
from
578c135
to
15514c2
Compare
HypeMC
changed the title
Options constructor visibility to public
@Slamdunk Done 😄 |
Slamdunk
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a custom implementation of the
RunnerInterfacethat decorates the default one, and I'd like to be able to modify some options in it.Currently, it's hard to instantiate a new
Optionsobject because the constructor is private, so I added awithmethod to help with that. I could also change the visibility of the constructor instead. I'd be ok with either approach, it'd just be nice to be able to do this.