Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.4 support #872

Open
wants to merge 14 commits into
base: 7.x
Choose a base branch
from
Open

Add PHP 8.4 support #872

wants to merge 14 commits into from

Conversation

joanhey
Copy link

@joanhey joanhey commented Aug 12, 2024

The tests pass, but show deprecations with the symfony/string v5.4.0 class in PHP 8.4 lowest test.

Symfony/string is fixed symfony/string@bce7504

PD: perhaps it'll be better to change in composer.json :

"require": {
        "php": "~8.2.0 || ~8.3.0 || ~8.4.0",

with

"require": {
        "php": ">=8.2",

Changed to "php": ">=8.2"

Fix #871
that break PestPHP pestphp/pest#1199

composer.json Outdated Show resolved Hide resolved
"php": "~8.2 || ~8.3 || ~8.4",

Constraints limited.
Used without the ".0" because have the same effect.
@joanhey joanhey changed the title Update to use PHP 8.4 Add PHP 8.4 in tests Aug 20, 2024
@Slamdunk
Copy link
Member

I don't like the CI build on 8.4 to be successful: https://github.com/paratestphp/paratest/actions/runs/10473712966/job/29006479710?pr=872#step:3:19

pcov is not yet compatible with 8.4, krakjoe/pcov#111

@Slamdunk Slamdunk changed the title Add PHP 8.4 in tests Add PHP 8.4 support Sep 25, 2024
@Slamdunk
Copy link
Member

Apparently there's an infinite loop somewhere with PHP 8.4, but I can't debug it yet locally because the pcov PECL extension hasn't been updated yet, we need to wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support PHP 8.4
3 participants