Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example for android #368

Merged
merged 6 commits into from
Jul 3, 2023
Merged

Added example for android #368

merged 6 commits into from
Jul 3, 2023

Conversation

Randommist
Copy link
Contributor

@Randommist Randommist commented Jun 25, 2023 •
edited
Loading

solves the issue #367

parasyte
parasyte requested changes Jul 1, 2023
View reviewed changes
Copy link
Owner

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! It took me a few days to get around to this. I had to think a bit about drop order stuff, but revisiting the linked ticket, I'm confident that it does need to be addressed for soundness.

examples/minimal-winit-android/src/lib.rs Outdated Show resolved Hide resolved
examples/minimal-winit-android/src/lib.rs Outdated Show resolved Hide resolved
examples/minimal-winit-android/src/lib.rs Outdated Show resolved Hide resolved
@parasyte parasyte self-requested a review July 3, 2023 01:49
parasyte
parasyte approved these changes Jul 3, 2023
View reviewed changes
Copy link
Owner

@parasyte parasyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks.

@parasyte parasyte merged commit d140eba into parasyte:main Jul 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parasyte parasyte parasyte approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Randommist @parasyte