Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][Make] Fixing some small changes for building with OCCA's latest main #66

Merged
merged 2 commits into from
Jan 2, 2021

Conversation

noelchalmers
Copy link
Member

Some small tweaks to the build system here.

  • No longer hijacking OCCA's makefile in our build. We don't need anything set in there.
  • Linking libocca.so via rpath (which means no more needing LD_LIBRARY_PATH !)
  • Removing setting occa::env::OCCA_MEM_BYTE_ALIGN. This can now be set directly, outside of the build system.

@tcew
Copy link
Contributor

tcew commented Jan 2, 2021

Nice!

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Merging #66 (1e6c5cf) into master (eb1dcf5) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   84.08%   84.08%   -0.01%     
==========================================
  Files         257      257              
  Lines       20316    20315       -1     
==========================================
- Hits        17083    17082       -1     
  Misses       3233     3233              
Impacted Files Coverage Δ
libs/core/platformDeviceConfig.cpp 44.44% <ø> (-1.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb1dcf5...1e6c5cf. Read the comment docs.

@noelchalmers noelchalmers merged commit 4da1ef3 into master Jan 2, 2021
@noelchalmers noelchalmers deleted the bugfix/occaRefactor branch January 2, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants