[Solvers][Mesh] Add CFL condition calculation to solvers #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as advection solver
|
Using max velocity instead of dt ~ min(h/(lambda*N^2)) will be pessimistic |
|
Would you prefer calculating min(h/lambda) over all elements over computing min(h) and max(lambda)? |
|
I think so. Sorry for not noticing that before. |
|
Sounds good. No reason we cant do that with a small tweak. I also need to update some golden norms. Some have shifted slightly enough that units tests are failing. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 84.24% 84.14% -0.10%
==========================================
Files 257 256 -1
Lines 20049 20219 +170
==========================================
+ Hits 16890 17013 +123
- Misses 3159 3206 +47
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability in each time-dependent solver to properly calculate the CFL timestep restriction. Currently, all solvers will only do this calculation once, after the initial condition is set. Aside from being slightly more robust when starting timestepping, this may be useful in the future for some timesteppers to adapt the timestep size.
This PR also addresses #25.