plugin::genericjmx::connection - Use data types

- Breaking change: collect now only accepts an array, not either an
  array or string

manifests/plugin/genericjmx/connection.pp

@@ -1,11 +1,11 @@
 # https://collectd.org/wiki/index.php/Plugin:GenericJMX
 define collectd::plugin::genericjmx::connection (
-  $collect,
-  $service_url,
-  $host            = undef,
-  $user            = undef,
-  $password        = undef,
-  $instance_prefix = undef,
+  Array $collect,
+  String $service_url,
+  Optional[String] $host            = undef,
+  Optional[String] $user            = undef,
+  Optional[String] $password        = undef,
+  Optional[String] $instance_prefix = undef,
 ) {
 
   include ::collectd

spec/defines/collectd_plugin_genericjmx_connection_spec.rb

@@ -51,17 +51,17 @@
         it { is_expected.to contain_concat__fragment(concat_fragment_name).with_content(%r{Host "bar\.example\.com"}) }
       end
 
-      context 'collect array' do
+      context 'with a collect array of multiple values' do
         let(:params) do
           default_params.merge(collect: %w[foo bar baz])
         end
 
         it { is_expected.to contain_concat__fragment(concat_fragment_name).with_content(%r{Collect "foo".*Collect "bar".*Collect "baz"}m) }
       end
 
-      context 'collect string' do
+      context 'with a collect array of one value' do
         let(:params) do
-          default_params.merge(collect: 'bat')
+          default_params.merge(collect: %w[bat])
         end
 
         it { is_expected.to contain_concat__fragment(concat_fragment_name).with_content(%r{Collect "bat"}) }

templates/plugin/genericjmx/connection.conf.erb

@@ -3,7 +3,7 @@
   Host "<%= @host %>"
   <% end -%>
   ServiceURL "<%= @service_url %>"
-  <% Array(@collect).each do |collect| -%>
+  <% @collect.each do |collect| -%>
   Collect "<%= collect %>"
   <% end -%>
   <% if @user -%>