Skip to content

Feat/collateral swap 2 - borrow any #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Feat/collateral swap 2
merged 19 commits into from
Apr 21, 2023
Merged

Feat/collateral swap 2 - borrow any #373

merged 19 commits into from
Apr 21, 2023

Conversation

@0x8f701
Copy link
Contributor

@0x8f701 0x8f701 commented Apr 18, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

0x8f701 added 2 commits April 18, 2023 07:14
@0x8f701
fix: build
c6af96d 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
chore: cleanup
03adafe 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701 0x8f701 requested a review from a team as a code owner April 18, 2023 01:01
@0x8f701 0x8f701 marked this pull request as draft April 18, 2023 01:01
@0x8f701 0x8f701 changed the base branch from main to feat/collateral-swap-2 April 18, 2023 01:02
0x8f701 added 2 commits April 18, 2023 15:18
@0x8f701
feat: resolve some TODOs
0442403 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
feat: pass swapAdapter, swapPayload
b43887e 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701 0x8f701 changed the title Feat/collateral swap 2 any Feat/collateral swap 2 - borrow any Apr 18, 2023
0x8f701 added 5 commits April 19, 2023 07:31
@0x8f701
fix: stack too deep
c909b16 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: lint
9bbe1d4 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: buy tests
290d813 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: accept bid tests
a0f6fb3 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
Merge remote-tracking branch 'origin/feat/collateral-swap-2' into fea…
48c9a0a 
…t/collateral-swap-2-any
@0x8f701 0x8f701 marked this pull request as ready for review April 19, 2023 01:51
0x8f701 added 10 commits April 19, 2023 08:56
@0x8f701
chore: remove unused params
7cde8ca 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
chore: remove unused swapProvider
1262a8d 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: typo
de98923 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: typo & check srcToken
b605664 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
chore: emit missing event
8d94fef 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: basic borrow and swap
1029cfc 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
feat: add missing buy tests
92f14eb 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
fix: lint
cf0319b 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
feat: support non-listed token with underlying asset address function
ad9c004 
Signed-off-by: GopherJ <alex_cj96@foxmail.com>
@0x8f701
Merge branch 'feat/collateral-swap-2' into feat/collateral-swap-2-any
eb89e23
@0x8f701 0x8f701 merged commit 7f6f5a6 into feat/collateral-swap-2 Apr 21, 2023
@0x8f701 0x8f701 deleted the feat/collateral-swap-2-any branch April 21, 2023 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@0x8f701