Skip to content

Conversation

@WalidOfNow
Copy link
Contributor

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #324 (4334295) into main (042e0cb) will decrease coverage by 0.62%.
The diff coverage is 64.98%.

@@            Coverage Diff             @@
##             main     #324      +/-   ##
==========================================
- Coverage   74.88%   74.26%   -0.62%     
==========================================
  Files          82       84       +2     
  Lines        3711     3886     +175     
  Branches      697      727      +30     
==========================================
+ Hits         2779     2886     +107     
- Misses        566      623      +57     
- Partials      366      377      +11     
Impacted Files Coverage Δ
contracts/protocol/libraries/logic/SupplyLogic.sol 94.61% <ø> (+7.99%) ⬆️
...tracts/protocol/libraries/logic/UniswapV3Logic.sol 0.00% <0.00%> (ø)
contracts/protocol/pool/PoolCore.sol 72.00% <0.00%> (-4.28%) ⬇️
contracts/protocol/pool/PoolMarketplace.sol 64.28% <ø> (ø)
...ontracts/protocol/tokenization/NTokenUniswapV3.sol 12.30% <17.07%> (+8.14%) ⬆️
contracts/misc/AutoCompoundApe.sol 88.52% <40.00%> (-4.34%) ⬇️
...acts/misc/flashclaim/AirdropFlashClaimReceiver.sol 47.27% <70.00%> (+2.17%) ⬆️
...ntracts/protocol/tokenization/NTokenApeStaking.sol 74.19% <80.00%> (+0.11%) ⬆️
contracts/protocol/tokenization/NTokenBAKC.sol 82.14% <82.14%> (ø)
contracts/protocol/pool/PoolApeStaking.sol 85.26% <85.18%> (-0.82%) ⬇️
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant