Use a callable template param in DmpCeff
#120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Signed-off-by: Jan Malek <jmalek@antmicro.com>
Signed-off-by: Krzysztof Bieganski <kbieganski@antmicro.com>
kbieganski
force-pushed
the
dcalc-lambda-template
branch
from
3fc1f3d to
aa5b0bb
Compare
|
Can we get some feedback if possible? |
|
I have very little free time to deal with reviewing and validating optimizations that may be 4% faster on some test cases. And I am no fan of templates. So it is very low priority. |
hzeller
reviewed
Apr 7, 2025
| static void | ||
| newtonRaphson(const int max_iter, | ||
| double x[], | ||
| const int n, | ||
| const double x_tol, | ||
| // eval(state) is called to fill fvec and fjac. | ||
| function<void ()> eval, |
There was a problem hiding this comment.
Could the original slow-ness be because this is passed by value instead of const & ? I guess it depends on how much is captured with the call.
Maybe it helps to un-stall this PR if changing the signature to const function<void()> &eval could improve performance and don't require a callable template parameter.
|
Neither change makes enough of a difference to bother with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
std::functioninDmpCeff.ccwith a callable template param. Speeds up CTS in OpenROAD by about 1-3% on ORFS designs, up to 4% on some others. Also speeds up floorplanning by about 1%.Ibex (asap7)
Ibex (nangate45)
black_parrot (nangate45)