Windows needs msbuild for generate-bindings #592
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryan D. Ashby <bryan@l33t.codes>
…ust-tss-esapi into msbuild-windows-dep2
Signed-off-by: Muxi Yan <muxi.yan@beyondidentity.com>
Signed-off-by: Bryan D. Ashby <bryan@l33t.codes>
…ust-tss-esapi into msbuild-windows-dep2
|
No idea why things keep getting so wonky trying to create a simple PR here. |
|
Can someone either fix this up or just apply the change? |
|
it seems as if your commit is not based on the latest revision of main. That is why it looks so strange. So if you rebase your commit upon the latest from main and then sign it, it should look fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreated PR for #591