build: fixes for newer Rust #146
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapt newest best practices according to Clippy, fix compiler warnings. Also build mbedTLS concurrently for faster CI builds. Signed-off-by: Dmitrii Sharshakov <d3dx12.xx@gmail.com>
Author
|
@hug-dev hopefully this makes CI pass on both MSRV and current, could you please approve the workflow to run? Thank you! |
hug-dev
approved these changes
Nov 24, 2025
Member
hug-dev
left a comment
hug-dev
left a comment
There was a problem hiding this comment.
Thanks a lot for taking care of this repo ❤️
Will see who else could review it
Author
|
Thanks! It seems I missed this part when testing locally: I don't have mbedtls on the host system and have excluded those parts of CI. Will revisit using a container to execute all parts. Sorry for missing this. I'll most likely take care of that later this week or weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt newest best practices according to Clippy, fix compiler warnings.
Also build mbedTLS concurrently for faster CI builds.
Signed-off-by: Dmitrii Sharshakov d3dx12.xx@gmail.com