Skip to content

signature: Small signature optimization #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2024
Merged

signature: Small signature optimization #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions parsec-openssl-provider/src/signature/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,14 @@ unsafe extern "C" fn parsec_provider_signature_sign(
return Ok(OPENSSL_SUCCESS);
}

if (sigsize as usize) < siglength {
return Err(format!(
"Signature length is bigger than sigsize. Signature length: {}",
siglength
)
.into());
}

if tbs.is_null() {
return Err("Received unexpected NULL pointer as an argument.".into());
}
Expand All @@ -186,16 +194,12 @@ unsafe extern "C" fn parsec_provider_signature_sign(
.psa_sign_hash(key_name, tbs_slice, sign_algorithm)
.map_err(|e| format!("Parsec Client failed to sign: {:?}", e))?;

if sigsize >= sign_res.len() as u32 {
if siglength != sign_res.len() {
Err(format!("Unexpected signature length: {}", sign_res.len()).into())
} else {
std::ptr::copy(sign_res.as_ptr(), sig, sign_res.len());
*siglen = sign_res.len() as u32;
Ok(OPENSSL_SUCCESS)
} else {
Err(format!(
"Signature length is bigger than sigsize. Signature length: {}",
sign_res.len()
)
.into())
}
});

Expand Down