Skip to content

signature: Enable ECDSA signing #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024
Merged

signature: Enable ECDSA signing #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion parsec-openssl-provider-shared/e2e_tests/tests/sign.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ fn sign_verify(
Ok(())
}

#[ignore]
#[test]
fn test_signing_ecdsa() {
// Create a key beforehand using the parsec-tool and then run the test.
Expand Down
9 changes: 4 additions & 5 deletions parsec-openssl-provider/src/signature/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ unsafe extern "C" fn parsec_provider_signature_sign(
.get_provctx()
.get_client()
.psa_sign_hash(key_name, tbs_slice, sign_algorithm)
.map_err(|_| "Parsec Client failed to sign".to_string())?;
.map_err(|e| format!("Parsec Client failed to sign: {:?}", e))?;

if sigsize >= sign_res.len() as u32 {
std::ptr::copy(sign_res.as_ptr(), sig, sign_res.len());
Expand Down Expand Up @@ -224,8 +224,7 @@ const OSSL_FUNC_SIGNATURE_FREECTX_PTR: SignatureFreeCtxPtr = parsec_provider_sig
const OSSL_FUNC_SIGNATURE_SIGN_PTR: SignatureSignPtr = parsec_provider_signature_sign;
const OSSL_FUNC_SIGNATURE_SIGN_INIT_PTR: SignatureSignInitPtr = parsec_provider_signature_sign_init;

const PARSEC_PROVIDER_ECDSA_SIGN_IMPL: [OSSL_DISPATCH; 1] = [ossl_dispatch!()];
const PARSEC_PROVIDER_RSA_SIGN_IMPL: [OSSL_DISPATCH; 5] = [
const PARSEC_PROVIDER_SIGN_IMPL: [OSSL_DISPATCH; 5] = [
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_NEWCTX, OSSL_FUNC_SIGNATURE_NEWCTX_PTR) },
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_FREECTX, OSSL_FUNC_SIGNATURE_FREECTX_PTR) },
unsafe { ossl_dispatch!(OSSL_FUNC_SIGNATURE_SIGN, OSSL_FUNC_SIGNATURE_SIGN_PTR) },
Expand All @@ -242,13 +241,13 @@ pub const PARSEC_PROVIDER_SIGNATURE: [OSSL_ALGORITHM; 3] = [
ossl_algorithm!(
PARSEC_PROVIDER_ECDSA_NAME,
PARSEC_PROVIDER_DFLT_PROPERTIES,
PARSEC_PROVIDER_ECDSA_SIGN_IMPL,
PARSEC_PROVIDER_SIGN_IMPL,
PARSEC_PROVIDER_DESCRIPTION_ECDSA
),
ossl_algorithm!(
PARSEC_PROVIDER_RSA_NAME,
PARSEC_PROVIDER_DFLT_PROPERTIES,
PARSEC_PROVIDER_RSA_SIGN_IMPL,
PARSEC_PROVIDER_SIGN_IMPL,
PARSEC_PROVIDER_DESCRIPTION_RSA
),
ossl_algorithm!(),
Expand Down