Skip to content

Conversation

@anmiles
Copy link
Contributor

@anmiles anmiles commented Oct 27, 2025

Do not add pages dynamically unless autoPaging is enabled

🐛 Problem

JsPDF might add a blank page in advance even if autoPaging option is not enabled.
The reason is that some branches of autoPaging-related logic are executed despite the autoPaging option.

✅ Solution

  • Ensure that the appropriate branches of code are covered by checking the autoPaging option.

🧪 Pre-push checks

  • npm run build passes
  • npm run test-unit passes
  • npm run test-local passes
  • npm run lint passes

Copy link
Collaborator

@HackbrettXXX HackbrettXXX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good.

@HackbrettXXX HackbrettXXX merged commit e080935 into parallax:master Oct 28, 2025
7 checks passed
@anmiles
Copy link
Contributor Author

anmiles commented Oct 28, 2025

@HackbrettXXX thanks for merging! Do you have any plans on when the new version might be published to npm?

@HackbrettXXX
Copy link
Collaborator

I'll wait until all Hacktober PRs have been merged. So probably around mid November.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants