0.10.20 npm dist tarball may not be built properly

[ShadowZero3000]

I'm not a node expert, so this could entirely be me misunderstanding or misconfiguring something, but when I recently updated to 0.10.20, I started seeing errors like:

Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/app/node_modules/rocket-store/dist/mjs/utils/filesValidators.js' imported from /app/node_modules/rocket-store/dist/mjs/index.mjs

Digging in, I found that dist/mjs/index.mjs within the npm tarball, retrieved with wget $(npm view rocket-store dist.tarball) and unpackaged contains references to ./utils/filesValidators.js rather than ./utils/filesValidators.mjs (line 29) and similar things. Reading through the actual code in the repo, and the package build scripts, I would expect those to be .mjs references, and in fact the code in the repo under dist/mjs is correct. I'm not sure what would have caused these to be out of sync in the dist.tarball I retrieved from my npm command.

If this is somehow user error, I apologize for posting a bug, but it seems to me like something that should be affecting other users as well, and may be an indicator that something went wrong in the build and publish process.

If I can provide more detail or be of assistance, please let me know!

[ShadowZero3000]

I was able to work around this by utilizing npm install https://github.com/paragi/rocket-store-node/tarball/master for the record.

[paragi]

Hi, Thanks for taking the time to write this report.
I don’t have the time to look into this at the moment. If you do, please make a patch and a pull request. I would be happy to include your fix.
BR Simon