feat: enforce requireScope and support breaking change syntax#1
Open
feat: enforce requireScope and support breaking change syntax#1
Conversation
Add enforcement of the requireScope config option that was declared but unused. When requireScope is true, commits without a scope are rejected. Add Conventional Commits breaking change (!) syntax support for both type!: and type(scope)!: formats. Expand test suite from 24 to 32 tests. Nightshift-Task: commit-normalize Nightshift-Ref: https://github.com/marcus/nightshift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requireScopeconfig option (was declared but unused) — commits without a scope are now rejected whenrequireScope: true!) syntax support (type!:andtype(scope)!:)Test plan
bash tests/test_commit_msg.sh)!preserved in normalized outputrequireScope: truerejects commits without scoperequireScope: trueaccepts commits with scoperequireScope: false(default) allows commits without scopeAutomated by nightshift