Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add serial lock for lockfile tests #9403

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Jul 9, 2024

closes #9381

cargo t runs tests in the same process, hence there is a race condition here.

adds a global mutex to lock tests, these tests only take <100ms, so locking should be fine here, has no impact when run through nextest

@mattsse mattsse added the C-test A change that impacts how or what we test label Jul 9, 2024
@mattsse mattsse requested a review from DaniPopes July 9, 2024 16:45
@github-actions github-actions bot added the C-bug An unexpected or incorrect behavior label Jul 9, 2024
@mattsse mattsse added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit 7dab636 Jul 9, 2024
33 checks passed
@mattsse mattsse deleted the matt/add-serial-lock-to-lock-tests branch July 9, 2024 17:37
@emhane emhane mentioned this pull request Aug 30, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make pr failed of lockfile
3 participants