-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add blob support to the rollup ExEx #8028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
New feature or request
A-exex
Execution Extensions
C-example
Examples
labels
May 1, 2024
shekhirin
force-pushed
the
alexey/exex-rollup-blob
branch
from
May 1, 2024 15:44
f085718
to
3a84418
Compare
shekhirin
force-pushed
the
alexey/exex-rollup-blob
branch
from
May 1, 2024 20:54
3126390
to
9c1111f
Compare
shekhirin
force-pushed
the
alexey/exex-rollup-blob
branch
2 times, most recently
from
May 1, 2024 21:23
27f73b4
to
f70880f
Compare
shekhirin
force-pushed
the
alexey/exex-rollup-blob
branch
from
May 1, 2024 21:23
f70880f
to
ad82472
Compare
shekhirin
force-pushed
the
alexey/exex-rollup-blob
branch
from
May 2, 2024 14:46
5df4ac8
to
4090735
Compare
onbjerg
approved these changes
May 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm otherwise
gakonst
reviewed
May 2, 2024
mattsse
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7558
This PR adds support for rollup block submissions using either calldata or EIP-4844 blobs
reth/examples/exex/rollup/src/execution.rs
Lines 178 to 220 in b5ba0c2
As well as an additional check for the
blockDataHash
commitmentreth/examples/exex/rollup/src/execution.rs
Lines 222 to 225 in b5ba0c2
The diff is quite large due to moving decoding- and execution-related code to a separate file.