feat(net): add Framed ECIES implementation - #80
Merged
Merged
Conversation
Rjected
force-pushed
the
dan/add-ecies
branch
from
October 15, 2022 02:51
7c02c35 to
a3342b4
Compare
Rjected
changed the title
Rjected
force-pushed
the
dan/add-ecies
branch
from
October 15, 2022 02:56
a3342b4 to
cd8f07f
Compare
* adds std feature to reth-rlp
Rjected
force-pushed
the
dan/add-ecies
branch
from
October 15, 2022 03:10
6bb8176 to
fc89dd6
Compare
remove anyhow and strictly type all errors
gakonst
approved these changes
Oct 16, 2022
| [dependencies] | ||
| reth-rlp = { path = "../../common/rlp", features = ["derive", "ethereum-types", "std"] } | ||
| reth-primitives = { path = "../../primitives" } | ||
| anyhow = "1.0.65" |
| repository = "https://github.com/foundry-rs/reth" | ||
| readme = "README.md" | ||
|
|
||
| [dependencies] |
Member
There was a problem hiding this comment.
Are all of these deps required?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #79 (do not merge until #79 is in), and extracts out the ECIES implementation from
devp2p-rspre-GPL.This is changed slightly, no longer using the
Transporttrait and instead specifying thatIoisAsyncReadorAsyncWriteor both, depending on the situation.For example, when implementing
Stream,Ioshould beAsyncRead + Unpin, and when implementingSink,Ioshould beAsyncWrite + Unpin.A
HasRemoteAddrtrait is created, which is just used for tracing instrumentation, since the current instruments rely on theIohaving aremote_addrmethod.