-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): minimal viable ExEx #7565
Conversation
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
Co-authored-by: Alexey Shekhirin <a.shekhirin@gmail.com>
0aed582
to
d2962cc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cosmetic nits
examples/exex/minimal/src/main.rs
Outdated
let this = self.get_mut(); | ||
|
||
// Process all new chain state notifications until there are no more | ||
while let Poll::Ready(Some(notification)) = this.ctx.notifications.poll_recv(cx) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while let Some(notification) = ready!(
and return Ok(()) on end
old.first().number..=old.tip().number, | ||
new.first().number..=new.tip().number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: include hashes of the old/new tip otherwise it might look confusing if we reorg a similar chain length
Closes #7557