chore(cli): fix clap deprecated warnings #6872
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warning: use of deprecated function `<commands::db::get::Command as clap::Args>::augment_args::old_attribute`: Attribute `#[clap(...)]` has been deprecated in favor of `#[arg(...)]` --> bin/reth/src/commands/db/get.rs:27:7 | 27 | #[clap(long)] | ^^^^ | = note: `#[warn(deprecated)]` on by default
warning: use of deprecated function `<args::network_args::DiscoveryArgs as clap::Args>::augment_args::id_is_only_for_arg`: `#[arg(name)] was allowed by mistake, instead use `#[arg(id)]` or `#[arg(value_name)]`
--> crates/node-core/src/args/network_args.rs:218:36
|
218 | #[arg(long = "discovery.port", name = "discovery.port", value_name = "DISCOVERY_PORT", default_value_t = DEFAULT_DISCOVERY_PORT)]
| ^^^^
mattsse
added
S-blocked
shekhirin
force-pushed
the
dani/clap-deprecated
branch
from
285d161 to
c811d90
Compare
shekhirin
force-pushed
the
dani/clap-deprecated
branch
from
c811d90 to
5bbf8f1
Compare
shekhirin
approved these changes
Feb 29, 2024
shekhirin
added
C-debt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all warnings reported by
cargo check --features clap/deprecated, see individual commits