Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add validate transactions function #5010

Merged
merged 1 commit into from
Oct 13, 2023
Merged

feat: add validate transactions function #5010

merged 1 commit into from
Oct 13, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 13, 2023

adds a new default fn to the TransactionValidator to validate many

@mattsse mattsse requested a review from Rjected October 13, 2023 10:29
@mattsse mattsse added A-tx-pool Related to the transaction mempool C-enhancement New feature or request M-changelog This change should be included in the changelog labels Oct 13, 2023
@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Merging #5010 (81f8ea3) into main (34bc498) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/transaction-pool/src/validate/eth.rs 7.26% <0.00%> (-0.11%) ⬇️
crates/transaction-pool/src/validate/mod.rs 65.71% <0.00%> (-6.17%) ⬇️

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.85% <0.00%> (-0.01%) ⬇️
unit-tests 62.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.93% <ø> (ø)
blockchain tree 80.81% <ø> (ø)
pipeline 88.37% <ø> (ø)
storage (db) 74.40% <ø> (ø)
trie 94.51% <ø> (+0.03%) ⬆️
txpool 48.02% <0.00%> (-0.14%) ⬇️
networking 76.44% <ø> (-0.02%) ⬇️
rpc 57.99% <ø> (+<0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 27.89% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 86.21% <ø> (-0.02%) ⬇️

Rjected
Rjected approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Rjected Rjected added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit 411893e Oct 13, 2023
23 checks passed
@Rjected Rjected deleted the matt/add-validate-transactions-fn branch October 13, 2023 20:10
mattsse added a commit that referenced this pull request Nov 8, 2023
@mattsse
feat: add validate transactions function (#5010)
d91951d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

Assignees
No one assigned
Labels
A-tx-pool Related to the transaction mempool C-enhancement New feature or request M-changelog This change should be included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mattsse @Rjected