Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ef-tests): seal engine typo and deserialization #4997

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

rkrasiuk
Copy link
Member

Description

  • fix typo: self_engine -> seal_engine
  • fix SealEngine deserialization: should be PascalCase instead of camelCase. see json schema

NOTE: contrary to the schema we omit SealEngine::Ethash since it has been deprecated and no longer used

@rkrasiuk rkrasiuk added C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test labels Oct 12, 2023
@rkrasiuk rkrasiuk requested a review from rakita October 12, 2023 13:14
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #4997 (8df4faf) into main (505c6bc) will decrease coverage by 0.02%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

Impacted file tree graph

see 43 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.85% <ø> (+0.44%) ⬆️
unit-tests 62.41% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.61% <ø> (-0.01%) ⬇️
blockchain tree 80.64% <ø> (ø)
pipeline 88.37% <ø> (-0.09%) ⬇️
storage (db) 74.40% <ø> (ø)
trie 94.51% <ø> (+0.03%) ⬆️
txpool 48.27% <ø> (-0.04%) ⬇️
networking 76.43% <ø> (+0.33%) ⬆️
rpc 57.96% <ø> (+0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 27.89% <ø> (+0.10%) ⬆️
payload builder 7.96% <ø> (ø)
primitives 86.29% <ø> (-0.06%) ⬇️

@rkrasiuk rkrasiuk added this pull request to the merge queue Oct 12, 2023
Merged via the queue into main with commit 422f38a Oct 12, 2023
23 checks passed
@rkrasiuk rkrasiuk deleted the rkrasiuk/ef-tests-fix-typo branch October 12, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug An unexpected or incorrect behavior C-test A change that impacts how or what we test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants