Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moving Log::from_primitive to rpc compat crate #4968

Merged
merged 2 commits into from
Oct 10, 2023
Merged

moving Log::from_primitive to rpc compat crate #4968

merged 2 commits into from
Oct 10, 2023

Conversation

i-m-aditya
Copy link
Contributor

Closes #4967

@codecov
Copy link

codecov bot commented Oct 10, 2023 •
edited
Loading

Codecov Report

Merging #4968 (76b52b1) into main (67773ad) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/rpc/rpc-types/src/eth/log.rs 100.00% <ø> (+37.14%) ⬆️
crates/rpc/rpc-types-compat/src/log.rs 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.26% <0.00%> (ø)
unit-tests 62.57% <0.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.76% <ø> (ø)
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.41% <ø> (ø)
trie 94.44% <ø> (ø)
txpool 48.98% <ø> (+0.46%) ⬆️
networking 76.09% <ø> (+0.01%) ⬆️
rpc 58.06% <0.00%> (+<0.01%) ⬆️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 85.45% <ø> (+0.03%) ⬆️

mattsse
mattsse approved these changes Oct 10, 2023
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, ty

@mattsse mattsse added C-debt Refactor of code section that is hard to understand or maintain A-rpc Related to the RPC implementation labels Oct 10, 2023
@mattsse mattsse added this pull request to the merge queue Oct 10, 2023
Merged via the queue into paradigmxyz:main with commit fb96369 Oct 10, 2023
23 checks passed
@mattsse mattsse mentioned this pull request Oct 10, 2023
Closed
mattsse added a commit that referenced this pull request Nov 8, 2023
@i-m-aditya @mattsse
moving Log::from_primitive to rpc compat crate (#4968)
0a6d447 
Co-authored-by: Matthias Seitz <matthias.seitz@outlook.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

Assignees
No one assigned
Labels
A-rpc Related to the RPC implementation C-debt Refactor of code section that is hard to understand or maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Log::from_primitive to rpc-compat crate
2 participants
@i-m-aditya @mattsse