Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use pending block tag for actual pending block #4966

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Oct 10, 2023

Closes #4965

this fixes a bug were we used the pending block (inside tree) hash to lookup the state, however the state_at fn only checks canonical blocks if a hash is provided

@mattsse mattsse requested a review from rkrasiuk October 10, 2023 11:19
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Oct 10, 2023
@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #4966 (559e79d) into main (1cccd09) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

Files Coverage Δ
crates/storage/provider/src/traits/state.rs 27.11% <ø> (ø)
crates/rpc/rpc/src/eth/api/transactions.rs 30.76% <0.00%> (ø)
crates/rpc/rpc/src/eth/api/mod.rs 61.19% <0.00%> (-0.31%) ⬇️
crates/storage/provider/src/providers/mod.rs 21.42% <0.00%> (-0.06%) ⬇️
crates/rpc/rpc/src/eth/api/pending_block.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

Flag Coverage Δ
integration-tests 15.26% <0.00%> (-0.02%) ⬇️
unit-tests 62.53% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
reth binary 30.76% <ø> (ø)
blockchain tree 80.63% <ø> (ø)
pipeline 88.45% <ø> (ø)
storage (db) 74.40% <0.00%> (-0.01%) ⬇️
trie 94.52% <ø> (ø)
txpool 48.52% <ø> (ø)
networking 76.08% <ø> (-0.08%) ⬇️
rpc 58.02% <0.00%> (-0.04%) ⬇️
consensus 63.01% <ø> (ø)
revm 27.79% <ø> (ø)
payload builder 7.96% <ø> (ø)
primitives 85.43% <ø> (-0.02%) ⬇️

Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Rjected Rjected added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit e042922 Oct 11, 2023
23 checks passed
@Rjected Rjected deleted the matt/use-pending-tag-for-pending-block branch October 11, 2023 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing on pending block can result in block not found
2 participants